build: rename caren-helm-reg to better match role #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
requested review from
faiq,
jimmidyson,
supershal and
thunderboltsid
jimmidyson
approved these changes
Nov 7, 2024
Contributor
|
wdyt |
The caren-helm-reg image is no longer used as a registry. The word registry was also recently changed to repository.
dkoshkin
force-pushed
the
dkoshkin/build-rename-image-caren-helm-reg
branch
from
ce29b3b to
eb9e792
Compare
Contributor
|
No upgrade concerns, right? |
Contributor
Author
Not that I can think of, we've been changing these templates around in the last few releases and haven't seen any issues. |
dlipovetsky
approved these changes
Nov 13, 2024
Merged
jimmidyson
added a commit
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## 0.23.0 (2024-11-13) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Build with go 1.23.3 and upgrade all tools by @jimmidyson in #967 ### Fixes 🔧 * fix: Update mindthegap to fix cert rotation by @dlipovetsky in #971 * fix: image registries with no credentials but with a CA by @dkoshkin in #927 ### Other Changes * build: set helmRepository tag in list-images target by @dkoshkin in #968 * build: rename caren-helm-reg to better match role by @dkoshkin in #969 **Full Changelog**: v0.22.0...v0.23.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
While looking at #968 I noticed the image name.
The
caren-helm-regimage is no longer used as a registry. The word registry was also recently changed to repository in the templates.Renamed it to
cluster-api-runtime-extensions-bundle-initializer, but open to suggestions!Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: